FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.1

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
119 41 0 0

Files

Class Bugs
com.octo.captcha.engine.bufferedengine.BufferedEngineContainer 6
com.octo.captcha.engine.bufferedengine.ContainerConfiguration 6
com.octo.captcha.engine.bufferedengine.SimpleBufferedEngineContainer 4
com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer 9
com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer 4
com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer$DiskElement 1
com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager 11

com.octo.captcha.engine.bufferedengine.BufferedEngineContainer

Bug Category Details Line
Method com.octo.captcha.engine.bufferedengine.BufferedEngineContainer.getPersistentFeedings() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 293
Method com.octo.captcha.engine.bufferedengine.BufferedEngineContainer.getPersistentMemoryHits() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 297
Method com.octo.captcha.engine.bufferedengine.BufferedEngineContainer.getPersistentToVolatileSwaps() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 301
Method com.octo.captcha.engine.bufferedengine.BufferedEngineContainer.getVolatileMemoryHits() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 309
Method com.octo.captcha.engine.bufferedengine.BufferedEngineContainer.swapCaptchasFromPersistentToVolatileMemory() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 198
Redundant nullcheck of persistentBuffer, which is known to be non-null in com.octo.captcha.engine.bufferedengine.BufferedEngineContainer.BufferedEngineContainer(CaptchaEngine, CaptchaBuffer, CaptchaBuffer, ContainerConfiguration) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 85

com.octo.captcha.engine.bufferedengine.ContainerConfiguration

Bug Category Details Line
Method com.octo.captcha.engine.bufferedengine.ContainerConfiguration.ContainerConfiguration(Map, int, int, int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 63
Method com.octo.captcha.engine.bufferedengine.ContainerConfiguration.ContainerConfiguration(Map, int, int, int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 64
Method com.octo.captcha.engine.bufferedengine.ContainerConfiguration.ContainerConfiguration(Map, int, int, int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 65
Method com.octo.captcha.engine.bufferedengine.ContainerConfiguration.ContainerConfiguration(Map, int, int, int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 66
Method com.octo.captcha.engine.bufferedengine.ContainerConfiguration.ContainerConfiguration(Map, int, int, int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 67
Method com.octo.captcha.engine.bufferedengine.ContainerConfiguration.ContainerConfiguration(Map, int, int, int, int, int, boolean, Locale) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 113

com.octo.captcha.engine.bufferedengine.SimpleBufferedEngineContainer

Bug Category Details Line
Method com.octo.captcha.engine.bufferedengine.SimpleBufferedEngineContainer.SimpleBufferedEngineContainer(CaptchaEngine, CaptchaBuffer, CaptchaBuffer, ContainerConfiguration, int, int) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 42
Method com.octo.captcha.engine.bufferedengine.SimpleBufferedEngineContainer.SimpleBufferedEngineContainer(CaptchaEngine, CaptchaBuffer, CaptchaBuffer, ContainerConfiguration, int, int) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 44
Method com.octo.captcha.engine.bufferedengine.SimpleBufferedEngineContainer.SimpleBufferedEngineContainer(CaptchaEngine, CaptchaBuffer, CaptchaBuffer, ContainerConfiguration, int, int) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 54
Method com.octo.captcha.engine.bufferedengine.SimpleBufferedEngineContainer.SimpleBufferedEngineContainer(CaptchaEngine, CaptchaBuffer, CaptchaBuffer, ContainerConfiguration, int, int) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 55

com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer

Bug Category Details Line
com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.removeCaptcha(int, Locale) may fail to close java.sql.PreparedStatement BAD_PRACTICE ODR_OPEN_DATABASE_RESOURCE 156
Redundant nullcheck of rs which is known to be null in com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.clear() STYLE RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE 463
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.putAllCaptcha(Collection, Locale) BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 281
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.clear() BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 457
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.getLocales() BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 498
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.removeCaptcha(int, Locale) BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 153
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.removeCaptcha(int, Locale) BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 156
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.size() BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 358
A prepared statement is generated from a nonconstant String at com.octo.captcha.engine.bufferedengine.buffer.DatabaseCaptchaBuffer.size(Locale) BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 407

com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer

Bug Category Details Line
Inconsistent synchronization of com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer.totalSize; locked 83% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 485
Exception is caught when Exception is not thrown in com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer.remove(int, Locale) STYLE REC_CATCH_EXCEPTION 180
com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer.clearFile() ignores return value of java.io.File.createNewFile() CORRECTNESS RV_RETURN_VALUE_IGNORED 287
Unwritten field: com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer.maxDataSize CORRECTNESS UWF_UNWRITTEN_FIELD 574

com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer$DiskElement

Bug Category Details Line
com.octo.captcha.engine.bufferedengine.buffer.DiskCaptchaBuffer$DiskElement is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 437

com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager

Bug Category Details Line
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setLocaleRatio(String, double) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 313
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setLocaleRatio(String, double) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 317
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setLocaleRatio(String, double) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 319
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setLocaleRatio(String, double) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 326
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.getPersistentBufferSizesByLocales() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 446
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.getVolatileBufferSizeByLocales() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 425
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setFeedSize(int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 282
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setMaxPersistentMemorySize(int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 378
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setMaxVolatileMemorySize(int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 392
Method com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setSwapSize(int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 406
com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.getLocaleRatio() is unsynchronized, com.octo.captcha.engine.bufferedengine.manager.QuartzBufferedEngineManager.setLocaleRatio(String, double) is synchronized MT_CORRECTNESS UG_SYNC_SET_UNSYNC_GET 289